Fix build of dpctl with sycl nightly from 2025-01-18#1974
Merged
oleksandr-pavlyk merged 1 commit intomasterfrom Jan 19, 2025
Merged
Fix build of dpctl with sycl nightly from 2025-01-18#1974oleksandr-pavlyk merged 1 commit intomasterfrom
oleksandr-pavlyk merged 1 commit intomasterfrom
Conversation
The failure was caused by TwoOffsets_FixedDimStridedIndexer not being device copyable, consequence of not being trivially copyable, consequence of using const class members contrary to C++ coding guidelines. https://clang.llvm.org/extra/clang-tidy/checks/cppcoreguidelines/avoid-const-or-ref-data-members.html This change adheres to the guidelines by removing const qualifier in class members. This change also avoids unnecessary copy in constructors of fixed-dim-strided-indexers that take container arguments by values.
Contributor
Author
|
BTW, the build of main branch using latest SYCL bundle failed for this reason: https://github.com/IntelPython/dpctl/actions/runs/12848222222/job/35825346490 |
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_484 ran successfully. |
Collaborator
ndgrigorian
approved these changes
Jan 19, 2025
Collaborator
ndgrigorian
left a comment
ndgrigorian
left a comment
There was a problem hiding this comment.
LGTM! Thank you @oleksandr-pavlyk
In a follow-up PR, I will look over our other structs and classes to eliminate const members.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The failure was caused by TwoOffsets_FixedDimStridedIndexer not being device copyable, consequence of not being trivially copyable, consequence of using const class members contrary to C++ coding guidelines.
https://clang.llvm.org/extra/clang-tidy/checks/cppcoreguidelines/avoid-const-or-ref-data-members.html
This change adheres to the guidelines by removing const qualifier in class members.
This change also avoids unnecessary copy in constructors of fixed-dim-strided-indexers that take container arguments by values.